-
Notifications
You must be signed in to change notification settings - Fork 107
Custom Skill Builder #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Custom Skill Builder #750
Conversation
79d29ea
to
0eb4a21
Compare
8ce9ce8
to
4ed7f86
Compare
030b30b
to
1b32f11
Compare
- It's incompatible
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug.
I experienced this when beating levels normally across several sessions, but it behaves the same if you simply hit the Next Level hotkey (Page Down) before and after restart. |
Hmm yeah, seems that when loading a game, I need to update the "custom skill" parameters. You can easily test this by typing the SKILL cheat on loading a custom skill game (during new game session), and you'll see "skill 6 - (null)". I'll have to think on the best way to update that. |
113582e
to
0ae491e
Compare
Alright so I think I've found a solution. However I've added a condition (which I think will be fine), that only saves it in the saved game if it's a custom skill saved game. This way saves/loads made under the normal skills still work... Plus imo we don't need to store custom skill info for normal skills anyway. |
Thanks, it works now. |
@Pedro-Beirao asked me to port over Nyan's Custom Skill Builder functionality. It is based on Nugget Doom's implementation, but uses mapinfo skill properties (DSDA's original skills also use this).
In order to get the Custom Skill working correctly, a few changes to the menu system and a NOMONSTERS skill flag were added.
I'm sure there will be quite a bit of questions and thoughts on this, since it's a pretty big PR.